effects: Improve is_mutation_free_type to also include immutable type… #48220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out the original change was insufficient and I had to do the same thing for is_consistent_type also, so I pushed that commit here also. |
…s thereof Addresses an outstanding todo. The property is memoized in the datatype like `isbitstype`. It is possible for types to refer to themselves via fields, so some form of memoization is required to avoid an infinite recursion.
I called the data type property `isidentityfree`, which I think more accurately reflects what is being queried here.
Keno
force-pushed
the
kf/ismutationfree
branch
from
e9e79d6 to
318828c
Compare
aviatesk
added a commit
that referenced
this pull request
Jan 11, 2023
- set up the `isidentityfree` query as `ismutationfree` and refactor `is_consistent_type` a bit using it - move the special handling of `Module`-type's `mutationfree` bit to `Core.Compiler` since it is entangled with the implementation detail within `Core.Compiler`
aviatesk
added a commit
that referenced
this pull request
Jan 11, 2023
- set up the `isidentityfree` query as `ismutationfree` and refactor `is_consistent_type` a bit using it - move the special handling of `Module`-type's `mutationfree` bit to `Core.Compiler` since it is entangled with the implementation detail within `Core.Compiler`
aviatesk
added a commit
that referenced
this pull request
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s thereof
Addresses an outstanding todo. The property is memoized in the datatype like
isbitstype. It is possible for types to refer to themselves via fields, so some form of memoization is required to avoid an infinite recursion.