Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inference: enable :call inference in irinterp #49191

Merged
merged 2 commits into from
May 4, 2023
Merged

inference: enable :call inference in irinterp #49191

merged 2 commits into from
May 4, 2023

Conversation

aviatesk
Copy link
Member

Built on top of #48913, this commit enables :call inference in irinterp. In a case when some regression is detected, we can simply revert this commit rather than reverting the whole refactoring from #48913.

@nanosoldier runbenchmarks("inference", vs=":master")
@nanosoldier runtests()

@aviatesk aviatesk requested a review from Keno March 30, 2023 09:33
@aviatesk aviatesk added the compiler:inference Type inference label Mar 30, 2023
@aviatesk aviatesk mentioned this pull request Mar 30, 2023
Merged
4 tasks
@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - no performance regressions were detected. A full report can be found here.

@aviatesk aviatesk force-pushed the avi/irinterp-recurse-inf branch from 93f4b3f to 9207d2e Compare April 3, 2023 06:12
@aviatesk
Copy link
Member Author

aviatesk commented Apr 3, 2023

@nanosoldier runtests()

Base automatically changed from avi/irsv to master April 4, 2023 00:09
@aviatesk aviatesk force-pushed the avi/irinterp-recurse-inf branch 2 times, most recently from 1ee2fca to ab3fee7 Compare April 10, 2023 12:49
@aviatesk
Copy link
Member Author

@nanosoldier runbenchmarks(!"scalar", vs=":master")
@nanosoldier runtests()

@aviatesk aviatesk force-pushed the avi/irinterp-recurse-inf branch from ab3fee7 to ee5ef93 Compare April 10, 2023 12:50
@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@aviatesk aviatesk force-pushed the avi/irinterp-recurse-inf branch from ee5ef93 to e891443 Compare April 28, 2023 03:46
@aviatesk
Copy link
Member Author

@nanosoldier runbenchmarks("inference", vs=":master")
@nanosoldier runtests()

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@aviatesk
Copy link
Member Author

@nanosoldier runtests(["InformationGeometry", "KissMCMC", "Braket", "MPIMeasurements", "OutlierDetectionPython", "ClimaCore", "DifferentialForms", "LiteQTL", "Trixi2Vtk", "SubSIt", "Controlz", "Relief", "TensorRefinement"])

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@aviatesk aviatesk force-pushed the avi/irinterp-recurse-inf branch from e891443 to 0e822cd Compare April 28, 2023 14:51
@aviatesk
Copy link
Member Author

aviatesk commented Apr 28, 2023 •
edited
Loading

The failure of TensorRefinement was real. Now LimitedAccuracy can appear in irinterp, so we should include InferenceLattice for [typeinf|ipo]_lattice for irinterp. 0e822cd fixes it.

@aviatesk
Copy link
Member Author

@nanosoldier runbenchmarks("inference", vs=":master")
@nanosoldier runtests()

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@aviatesk aviatesk force-pushed the avi/irinterp-recurse-inf branch from 0e822cd to a8d99f7 Compare April 29, 2023 16:13
@aviatesk
Copy link
Member Author

@nanosoldier runbenchmarks(!"scalar", vs=":master")
@nanosoldier runtests(["EBayes", "DelaunayTriangulation", "Permanents", "OteraEngine", "ScikitLearn", "ASE", "LazySets", "SBMLToolkit", "Causal", "Decapodes", "Relief", "SubSIt"])

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

aviatesk added 2 commits May 4, 2023 14:21
@aviatesk
inference: enable :call inference in irinterp
500e985 
Built on top of #48913, this commit enables `:call` inference in irinterp.
In a case when some regression is detected, we can simply revert this
commit rather than reverting the whole refactoring from #48913.
@aviatesk
fix irinterp lattice
9436bf5 
Now `LimitedAccuracy` can appear in irinterp, so we should include
`InferenceLattice` for `[typeinf|ipo]_lattice` for irinterp.
@aviatesk aviatesk force-pushed the avi/irinterp-recurse-inf branch from a8d99f7 to 9436bf5 Compare May 4, 2023 07:26
@aviatesk
Copy link
Member Author

aviatesk commented May 4, 2023

@nanosoldier runbenchmarks(!"scalar", vs=":master")
@nanosoldier runtests(["EBayes", "DelaunayTriangulation", "Permanents", "OteraEngine", "ScikitLearn", "ASE", "LazySets", "SBMLToolkit", "Causal", "Decapodes", "Relief", "SubSIt"])

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - no new issues were detected.
A full report can be found here.

@aviatesk aviatesk merged commit c0e12cd into master May 4, 2023
@aviatesk aviatesk deleted the avi/irinterp-recurse-inf branch May 4, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Awaiting requested review from Keno

Assignees

@aviatesk aviatesk

Labels
compiler:inference Type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aviatesk @nanosoldier