Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssair: compact! constant PiNode #50768

Merged
merged 1 commit into from
Aug 3, 2023
Merged

ssair: compact! constant PiNode #50768

merged 1 commit into from
Aug 3, 2023

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Aug 2, 2023

Currently the compact!-ion pass fails to fold constant PiNode like PiNode(0.0, Float64). This commit fixes it up.

@aviatesk aviatesk requested a review from Keno August 2, 2023 19:32
@aviatesk
Copy link
Member Author

aviatesk commented Aug 2, 2023

@nanosoldier runbenchmarks("inference", vs=":master")

aviatesk
aviatesk commented Aug 2, 2023
View reviewed changes
base/compiler/ssair/ir.jl Outdated Show resolved Hide resolved
@aviatesk aviatesk added the backport 1.10 Change should be backported to the 1.10 release label Aug 2, 2023
@aviatesk aviatesk mentioned this pull request Aug 2, 2023
Merged
@aviatesk aviatesk force-pushed the avi/constant-pinode branch 2 times, most recently from 62774f7 to d39152d Compare August 2, 2023 19:59
@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - no performance regressions were detected. A full report can be found here.

@aviatesk
Copy link
Member Author

aviatesk commented Aug 2, 2023

@nanosoldier runbenchmarks("inference", vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@aviatesk aviatesk force-pushed the avi/constant-pinode branch 2 times, most recently from 736962a to 5dec1b6 Compare August 3, 2023 12:48
@aviatesk
ssair: compact! constant PiNode
5b49d06 
Currently the `compact!`-ion pass fails to fold constant `PiNode` like
`PiNode(0.0, Float64)`. This commit fixes it up.
@aviatesk aviatesk force-pushed the avi/constant-pinode branch from 5dec1b6 to 5b49d06 Compare August 3, 2023 12:51
@aviatesk
Copy link
Member Author

aviatesk commented Aug 3, 2023

@nanosoldier runbenchmarks("inference", vs=":master")

1 similar comment
@aviatesk
Copy link
Member Author

aviatesk commented Aug 3, 2023

@nanosoldier runbenchmarks("inference", vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - no performance regressions were detected. A full report can be found here.

@nanosoldier
Copy link
Collaborator

Your job failed.

@aviatesk aviatesk merged commit b3e8bd0 into master Aug 3, 2023
@aviatesk aviatesk deleted the avi/constant-pinode branch August 3, 2023 15:36
aviatesk added a commit that referenced this pull request Aug 3, 2023
@aviatesk
optimizer: move inlineable constants into argument position during `c…
a2f3d77 
…ompact!`-ion (#50767)

In code like below
```julia
Base.@assume_effects :nothrow function erase_before_inlining(x, y)
    z = sin(y)
    if x
        return "julia"
    end
    return z
end

let y::Float64
    length(erase_before_inlining(true, y))
end
```
the constant prop' can figure out the constant return type of
`erase_before_inlining(true, y)` while it is profitable not to inline
expand it since otherwise we left some `!:nothrow` callees there
(xref: #47305).

In order to workaround this problem, this commit makes `compact!`move
inlineable constants into argument positions so that the such
"inlineable, but safe as a whole" calls to be erased during compaction.
This should give us general compile-time performance improvement too
as we no longer need to expand the IR for those calls.

Requires:
- #50764
- #50765
- #50768
aviatesk added a commit that referenced this pull request Aug 4, 2023
@aviatesk
ssair: compact! constant PiNode (#50768)
2a70dac 
Currently the `compact!`-ion pass fails to fold constant `PiNode` like
`PiNode(0.0, Const(0.0))`. This commit fixes it up.
aviatesk added a commit that referenced this pull request Aug 4, 2023
@aviatesk
optimizer: move inlineable constants into argument position during `c…
9e9f67d 
…ompact!`-ion (#50767)

In code like below
```julia
Base.@assume_effects :nothrow function erase_before_inlining(x, y)
    z = sin(y)
    if x
        return "julia"
    end
    return z
end

let y::Float64
    length(erase_before_inlining(true, y))
end
```
the constant prop' can figure out the constant return type of
`erase_before_inlining(true, y)` while it is profitable not to inline
expand it since otherwise we left some `!:nothrow` callees there
(xref: #47305).

In order to workaround this problem, this commit makes `compact!`move
inlineable constants into argument positions so that the such
"inlineable, but safe as a whole" calls to be erased during compaction.
This should give us general compile-time performance improvement too
as we no longer need to expand the IR for those calls.

Requires:
- #50764
- #50765
- #50768
@aviatesk aviatesk removed the backport 1.10 Change should be backported to the 1.10 release label Aug 4, 2023
@aviatesk aviatesk mentioned this pull request Aug 4, 2023
Merged
36 tasks
KristofferC added a commit that referenced this pull request Aug 16, 2023
@KristofferC
Backports for julia v1.10.0-beta2 (#50708)
77e7e73 
Backported PRs:
- [x] #50637 <!-- Remove SparseArrays legacy code -->
- [x] #50665 <!-- print `@time` msg into print buffer -->
- [x] #50523 <!-- Avoid generic call in most cases for getproperty -->
- [x] #50635 <!-- `versioninfo()`: include build info and unofficial
warning -->
- [x] #50670 <!-- Make reinterpret specialize fully. -->
- [x] #50666 <!-- include `--pkgimage=no` caches for stdlibs -->
- [x] #50765 
- [x] #50764
- [x] #50768
- [x] #50767
- [x] #50618 <!-- inference: continue const-prop' when concrete-eval
returns non-inlineable -->
- [x] #50689 <!-- Attach `tanpi` docstring to method -->
- [x] #50671 <!-- Fix rdiv of complex lhs by real factorizations -->
- [x] #50598 <!-- only limit types in stack traces in the REPL -->
- [x] #50766 <!-- Don't partition alwaysinline functions -->
- [x] #50771 <!-- re-allow non-string values in ENV `get!` -->
- [x] #50682 <!-- Add fallback if we have make a weird GC decision. -->
- [x] #50781 <!-- fix `bit_map!` with aliasing -->
- [x] #50172 <!-- print feature flags used for matching pkgimage -->
- [x] #50844 <!-- Bump OpenBLAS binaries to use the new GEMM
multithreading threshold -->
- [x] #50826 <!-- Update dependency builds -->
- [x] #50845 <!-- fix #50438, use default pool for at-threads -->
- [x] #50568 <!-- `Array(::AbstractRange)` should return an `Array` -->
- [x] #50655 <!-- fix hashing regression. -->
- [x] #50779 <!-- Minor refactor to image generation -->
- [x] #50791 <!-- Make symbols internal in jl_create_native, and only
externalize them when partitioning -->
- [x] #50724 <!-- Merge opaque closure modules with the rest of the
workqueue -->
- [x] #50738 <!-- Add alignment to constant globals -->
- [x] #50871 <!-- macOS: Don't inspect dead threadtls during exception
handling. -->

Need manual backport:

Contains multiple commits, manual intervention needed:

Non-merged PRs with backport label:
- [ ] #50850 <!-- Remove weird Rational dispatch and add pi functions to
list -->
- [ ] #50823 <!-- Make ranges more robust with unsigned indexes. -->
- [ ] #50809 <!-- Limit type-printing in MethodError -->
- [ ] #50663 <!-- Fix Expr(:loopinfo) codegen -->
- [ ] #50594 <!-- Disallow non-index Integer types in isassigned -->
- [ ] #50385 <!-- Precompile pidlocks: add to NEWS and docs -->
- [ ] #49805 <!-- Limit TimeType subtraction to AbstractDateTime -->
@mofeing mofeing mentioned this pull request Oct 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Awaiting requested review from Keno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aviatesk @nanosoldier @Keno