show function arguments in different colors in method errors #50884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will #50809 make it easier to read? |
|
Oh good timing, yes that's another way to do it. Maybe we could still alternate colors in the full |
|
We shouldn't use black, since many people use dark terminal backgrounds and it's very hard to see. |
|
Yes I guess So maybe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have always struggled to read method errors. Past a degree of type complexity it becomes very hard to see where one argument stops and the next starts.
This PR gives each argument an alternating color, making it trivial to distinguish them.
We may want better colors than green and black, if anyone has opinions.