domtree: Optimize DFS! allocations
#52880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profiling downstream shows a lot of time spent `push!`ing into the worklist and creating temporary arrays (which in this case were just an indirect way of doing a `fill!(..., 0)`) These changes should mean we allocate zero new Array's when updating the DFS!, which is a frequent operation as part of updating the domtree when performing semi-concrete eval.
Keno
approved these changes
Jan 12, 2024
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
DFS!is a decent fraction of the work for updating the domtree, this should be a noticeable improvement to semi-concrete eval for very large functions.Profiling downstream shows a lot of time spent
push!ing into the worklist and creating temporary arrays.