Fix spurious unused function warning when compiling crc32 with clang and ifunc support #53897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and ifunc support Clang incorrectly warns functions only used through ifuncs are unused, llvm/llvm-project#63957.
|
Would suggest caution before considering this PR, given the ifunc-based backdoor also noted in the mentioned PR. More info: https://www.openwall.com/lists/oss-security/2024/03/29/4 |
vtjnash
approved these changes
Mar 29, 2024
vtjnash
reviewed
Mar 29, 2024
|
Not sure what couponing attributes are, so don't think I can help much in that regard. |
|
Also suspicious that the LLVM issue is by the xz backdoor person, but the change LGTM |
|
Wording seems to have been some autocorrect issue (now fixed above). Looks like MaskRay is fixing this upstream now in clang, so we may not need this (or we might be able to replace this with the UNUSED macro that we have used elsewhere to override the warning) |
|
Presumably, the fix to clang won't get backported so it would be nice to fix this. |
Zentrik
added a commit
to Zentrik/julia-buildkite
that referenced
this pull request
Apr 21, 2024
Zentrik
added a commit
to Zentrik/julia-buildkite
that referenced
this pull request
Apr 21, 2024
Zentrik
added a commit
to Zentrik/julia-buildkite
that referenced
this pull request
Apr 21, 2024
Zentrik
added a commit
to Zentrik/julia-buildkite
that referenced
this pull request
Apr 21, 2024
Zentrik
added a commit
to Zentrik/julia-buildkite
that referenced
this pull request
Jul 26, 2024
Zentrik
added a commit
to Zentrik/julia-buildkite
that referenced
this pull request
Jul 28, 2024
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Aug 17, 2024
…and ifunc support (JuliaLang#53897) Clang incorrectly warns functions only used through ifuncs are unused, llvm/llvm-project#63957.
Zentrik
added a commit
to Zentrik/julia-buildkite
that referenced
this pull request
Aug 22, 2024
Zentrik
added a commit
to Zentrik/julia-buildkite
that referenced
this pull request
Aug 25, 2024
Zentrik
added a commit
to Zentrik/julia-buildkite
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang incorrectly warns functions only used through ifuncs are unused, llvm/llvm-project#63957.