use atomic-fetch-and in write barrier slow-path #54744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Jun 9, 2024
|
Hmm. Perhaps use fetch-and-relaxed then? |
|
Possibly? I guess processors usually have some sort of lock and, so it shouldn't cost more then a lock xchg? |
d-netto
force-pushed
the
dcn-fetch-and-in-wb
branch
from
e72e694 to
f84e986
Compare
d-netto
added a commit
to RelationalAI/julia
that referenced
this pull request
Jun 28, 2024
Not sure why we're not using it, but we probably should.
d-netto
added a commit
to RelationalAI/julia
that referenced
this pull request
Jul 3, 2024
Not sure why we're not using it, but we probably should.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why we're not using it, but we probably should.