Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an assertion to ensure we're not cleaning-up GC state for GC threads #55233

Merged
merged 1 commit into from
Jul 25, 2024
Merged

add an assertion to ensure we're not cleaning-up GC state for GC threads #55233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/gc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3715,8 +3715,9 @@ static int _jl_gc_collect(jl_ptls_t ptls, jl_gc_collection_t collection)
}
// free empty GC state for threads that have exited
if (jl_atomic_load_relaxed(&ptls2->current_task) == NULL) {
if (gc_is_parallel_collector_thread(t_i))
continue;
// GC threads should never exit
assert(!gc_is_parallel_collector_thread(t_i));
assert(!gc_is_concurrent_collector_thread(t_i));
jl_thread_heap_t *heap = &ptls2->gc_tls.heap;
if (heap->weak_refs.len == 0)
small_arraylist_free(&heap->weak_refs);
Expand Down