Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAPACK: return union of tuples in gees and trsen #55353

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Aug 2, 2024

This simplifies the return type from a Tuple with a Union field to a Union of Tuples.

@jishnub jishnub added the linear algebra Linear algebra label Aug 2, 2024
@dkarrasch
Copy link
Member

Does that make a difference somewhere downstream?

@jishnub
Copy link
Contributor Author

jishnub commented Aug 4, 2024

I couldn't ascertain a direct impact at the moment, but a Union of Tuples is easier on type-inference as union-spliting may ensure that there is no dynamic dispatch. @code_warntype LAPACK.gees!('V', rand(2,2)) shows the result in yellow in this PR vs in red on master.

@ViralBShah
Copy link
Member

Good to merge then?

@jishnub jishnub merged commit 308cd7b into master Aug 6, 2024
8 checks passed
@jishnub jishnub deleted the jishnub/lapackrettype branch August 6, 2024 16:42
lazarusA pushed a commit to lazarusA/julia that referenced this pull request Aug 17, 2024
This simplifies the return type from a `Tuple` with a `Union` field to a
`Union` of `Tuple`s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants