Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Documenter 1.4.0 => 1.8.0 #56538

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Update Documenter 1.4.0 => 1.8.0 #56538

merged 1 commit into from
Nov 13, 2024

Conversation

mortenpi
Copy link
Contributor

@mortenpi mortenpi commented Nov 13, 2024 •
edited
Loading

Includes a bunch small change, but importantly the fix for the search not opening.

I think we should also backport this to 1.10 and 1.11, but those should probably be done manually, to avoid manifest conflicts. Should I just PR the relevant release-* branches?

@mortenpi mortenpi requested a review from fredrikekre November 13, 2024 03:58
fredrikekre
fredrikekre approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I just PR the relevant release-* branches?

Probably the easiest yea.

@fredrikekre fredrikekre merged commit c5ee5db into JuliaLang:master Nov 13, 2024
6 of 8 checks passed
@mortenpi mortenpi deleted the mp/documenter branch November 13, 2024 19:52
@mortenpi mortenpi mentioned this pull request Nov 13, 2024
Merged
@mortenpi
Copy link
Contributor Author

I think we should also backport this to 1.10 and 1.11

1.11 is #56550.

I noticed that 1.10 actually uses 0.27.23, so doesn't have the search bug (by virtue of not having the new UI), so no real need to backport. Also, 1.11 docs are the main ones that we show to users anyway, so I don't think it's really worth updating Documenter for 1.10.

KristofferC pushed a commit that referenced this pull request Nov 14, 2024
@mortenpi
[backports-release-1.11] Update Documenter v1.3.0 => v1.8.0 (#56550)
3e0c47c 
Manual "backport" of #56538. I assume we want this against
#56228 ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mortenpi @fredrikekre