Updated noteworthy-differences document. #6221
Conversation
|
The mention of the = is so readers know what to use in Julia instead of the R assignment. This seems useful, why remove it? |
|
I comment about the |
| ``lapply(<structure>, function, arg2, ...)`` in R. | ||
| - Julia uses ``end`` to denote the end of conditional blocks, like ``if``, | ||
| loop blocks, like ``while``/``for``, and functions. This makes | ||
| ``if ( cond ) statement`` impossible to do. |
There was a problem hiding this comment.
You can do
cond && statement
# and
if cond; statement; end
| `Distributions package <https://github.com/JuliaStats/Distributions.jl>`_ | ||
| - The `DataFrames package <https://github.com/HarlanH/DataFrames.jl>`_ | ||
| provides data frames. | ||
| - Formulas for GLM's must be escaped: use ``:(y ~ x)`` instead of ``y ~ x``. |
There was a problem hiding this comment.
@johnmyleswhite Is this still correct in light of #4882?
There was a problem hiding this comment.
Yes, this is going to be false once 0.3 comes out.
|
Thanks for doing this. Just a few comments. |
|
@johnmyleswhite Hopefully these changes work correctly. If not I'll edit once more and get this up. |
| follows the name of a specific variable, unlike R, for which ... can occur | ||
| in isolation. | ||
| - Modulus in Julia is %, not %%. | ||
| - Julia does not have the option of slicing with a logical index vector. |
There was a problem hiding this comment.
[1:3][[true, false, true]] and even "abc"[[true, false, true]] work. What do you have in mind?
There was a problem hiding this comment.
Removed from commit.
|
bump? the fact that this change mixes formatting with content makes it really hard to review. |
|
@StefanKarpinski Have you tried the rendered diff? I find it much clearer for doc changes. |
|
Bump. Good to merge? |
|
Are there any other problems left I should fix? Haven't seen this merged in. |
|
This needs to be rebased and the comment about needing to escape |
Signed-off-by: David Tran <[email protected]>
|
Rebased and merged my commits. |
|
lgtm |
|
Is github showing the wrong diff somehow, or have many of the reviewer comments not been addressed yet? |
|
Huh, where did all the other changes go? |
|
@JeffBezanson I don't see issues on my end or did the rebase and merge not work right? For reference I followed this: https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request |
|
@unsignedzero Your rebase didn't come through for some reason. Could you try again? Also, it'd be nice to have a more descriptive commit message than "Merged notes with master branch. Applied changes from jiahao." |
jiahao
force-pushed
the
master
branch
3 times, most recently
from
6c7c7e3 to
1a4c02f
Compare
|
I don't know what happened to the most recent batch of changes from September, but I've gone through and fixed this PR manually, adding in unaddressed comments and basically rewrote the file for clarity and consistency. |
Also fix sublist whitespace errors. Ref: #6221
|
I presume at this point the merge is completed and all is well then? |
|
Documentation's never done, but these contributions were merged in afaict |
Updated the noteworthy-differences document:
80 characters or less in each line.
R does allow you to use = so that's removed.
Important/annoying differences for R noted.
Added new differences for Python.