Remove ! versions of CholmodSparse and lufact to avoid invalid sparse matrices as discussed in #9472. #9803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
force-pushed
the
anj/sparse!
branch
from
fd77413 to
7878c6e
Compare
andreasnoack
changed the title
andreasnoack
added a commit
that referenced
this pull request
Jan 16, 2015
Remove ! versions of CholmodSparse and lufact to avoid invalid sparse matrices as discussed in #9472.
|
Thanks. This is certainly the right thing to do. |
|
This broke some packages, shouldn't there be something in NEWS or a deprecation warning or something? |
|
What you must learn is that these rules are no different from the rules of a computer system. |
matrixmorpheus
added a commit
to matrixmorpheus/julia
that referenced
this pull request
Jan 17, 2015
Some rules can be bent. JuliaLang#9803 Others can be broken. JuliaLang#9779
Closed
|
I literally can't even @matrixmorpheus |
matrixmorpheus
added a commit
to matrixmorpheus/julia
that referenced
this pull request
Jan 17, 2015
Some rules can be bent. JuliaLang#9803 Others can be broken. JuliaLang#9779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For sparse matrices there is only a tiny saving from avoiding the allocation of a temporary array with zero based indexing and because we are using
@inboundsin the sparse code, it is important to avoid invalid sparse matrices.