-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add juliaup-init installer for Windows, Linux and OSX #143
Merged
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bd15106
Add juliaup-init polyglot installer
heetbeet 554c653
Update readme
heetbeet ddf0917
Update README.md
heetbeet b33cbce
Update README.md
heetbeet d121431
Update README.md
heetbeet 94e71e8
Update juliaup-init.sh.cmd
heetbeet 427e5fc
Use relative symlink for linking julialauncher to julia in bin path
heetbeet 49eed56
Update README.md
heetbeet 0fc2deb
Slightly shorter github url s
heetbeet 929d452
Redundant info in readme
heetbeet 42b8269
Update pull request comments
heetbeet 9cda100
Merge branch 'master' into pr/heetbeet/143
davidanthoff 8427022
Remove README updates for script
davidanthoff 9b8a12a
Move shell install scripts
davidanthoff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should recommend linking things in
$HOME
to things in/usr/local
./usr/local
is a system-wide install location$HOME
is specific for your userIf there's any other users on the system this won't work well for them as all the files will reside in your specific
$HOME
directory with your permissions.A better alternative is to recommend the use of the
$HOME/.local/bin
directory which is part of the XDG standard:Perhaps
juliaup
itself could be installed into$HOME/.local/bin/juliaup
and we could skip the symlinks completely? If that's not possible, we can symlink it in there.See also https://unix.stackexchange.com/questions/316765/which-distributions-have-home-local-bin-in-path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, it's messy symlinking user-level things to system-wide directories. Will think a bit about this... It might be worth asking the user if the path should be appended in ~/.bashrc like conda and rust does is. I have a strange feeling about installing it flat into
$HOME/.local/bin/
, since I want to be able to delete the whole directory (such as~/.juliaup/bin
) and not have side effects.