Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests #21

Merged
merged 8 commits into from
Jan 25, 2022
Merged

Update tests #21

merged 8 commits into from
Jan 25, 2022

Conversation

eliascarv
Copy link
Member

@eliascarv eliascarv commented Jan 24, 2022

Update tests so they work on CI and different versions of Julia.

@eliascarv
Copy link
Member Author

This PR is ready for review @juliohm.

test/transforms.jl Outdated Show resolved Hide resolved
Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing @eliascarv , just a few minor suggestions.

test/transforms.jl Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
test/transforms.jl Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
@juliohm
Copy link
Member

juliohm commented Jan 25, 2022

Fixes #18

@juliohm juliohm merged commit ce70534 into JuliaML:master Jan 25, 2022
@juliohm
Copy link
Member

juliohm commented Jan 25, 2022

Awesome work @eliascarv. Feel free to take a new issue from the list of open issues 👍🏽

@eliascarv eliascarv deleted the up-test branch January 25, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants