Adding a Glue Type / N-Body Empirical Potential - the Finnis-Sinclair 1984 potential for single element systems #32
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,10 @@ | ||
| [deps] | ||
| DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0" | ||
| Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4" | ||
| Molly = "aa0f7f06-fcc0-5ec4-a7f3-a573f33f9c4c" | ||
| Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80" | ||
|
There was a problem hiding this comment. The plots in the documentation could be generated during the docs build, but it would be ideal to use the same package for all the plots (preferably one of the Makie backends). @jgreener64 One idea would be to use There was a problem hiding this comment. It would indeed be better to use the same plotting package throughout, though at the minute the code in the docs is not run during the docs build and Makie plots are pasted as images into the doc files. It would be good if the docs notebook appeared in the docs - perhaps it could go in the examples section as markdown. Then these docs dependencies can be removed until we deal with doctests later, as the examples can assume that users have the package installed. There was a problem hiding this comment. Tried using |
||
| SingleCrystal = "3c6eccdf-2a89-4c24-a1d4-ff210daa8476" | ||
| Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | ||
|
|
||
| [compat] | ||
| Documenter = "0.25" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is
SingleCrystaladded as a dependency of the package? Should it not be just a test dependency?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, thanks, should be fixed, as soon as I push my changes.