Use @test_broken instead of skipping
#1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes one failure in L-BFGS that causes CI to fail.
timholy
force-pushed
the
teh/test_broken
branch
from
5e63789 to
15cd43d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1105 +/- ##
==========================================
- Coverage 85.46% 85.26% -0.20%
==========================================
Files 45 45
Lines 3274 3502 +228
==========================================
+ Hits 2798 2986 +188
- Misses 476 516 +40 ☔ View full report in Codecov by Sentry. |
|
Green! Yay! |
avik-pal
pushed a commit
to avik-pal/Optim.jl
that referenced
this pull request
Nov 19, 2024
A global flag, test_broken (default false), determines whether this runs during CI. Locally it's useful to be able to tally the failures, e.g., JuliaNLSolvers#1104 Also: - Fix one failure in L-BFGS that causes CI to fail - Remove several tests from the exclusions lists that now pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A global flag,
test_broken = false, determines whether this runs during CI.Locally it's useful to be able to tally the failures, e.g., #1104
This also fixes one failure in L-BFGS that causes CI to fail.