Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenBLAS] Add v0.3.20 #4485

Merged
merged 3 commits into from
Feb 23, 2022
Merged

[OpenBLAS] Add v0.3.20 #4485

merged 3 commits into from
Feb 23, 2022

Conversation

giordano
Copy link
Member

No description provided.

@giordano giordano force-pushed the mg/openblas branch 2 times, most recently from 55555dc to 7c48cda Compare February 22, 2022 16:30
@@ -0,0 +1,19 @@
diff --git a/kernel/arm64/KERNEL.NEOVERSEN1 b/kernel/arm64/KERNEL.NEOVERSEN1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Keno: OpenMathLib/OpenBLAS#3052 supposedly fixed the issue you reported at OpenMathLib/OpenBLAS#2998, did you ever get a chance to verify whether we can drop this patch now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, I verified the patch should now be redundant, as vanilla OpenBLAS now produces the right result: #7202 (comment).

@giordano giordano added julia 💜 ❤️ 💚 Builders and issues related to Julia and its dependencies linear algebra 🔢 labels Feb 22, 2022
@giordano
Copy link
Member Author

giordano commented Feb 22, 2022

When building for x86_64 with GCC and libgfortran3 (so GCC 6):

[17:11:19] ../libopenblas64_p-r0.3.20.a(dgemm_small_kernel_nn_SKYLAKEX.o): In function `dgemm_small_kernel_nn_SKYLAKEX':
[17:11:19] dgemm_small_kernel_nn_skylakex.c:(.text+0x2ddd): undefined reference to `_mm512_reduce_add_pd'
[17:11:19] dgemm_small_kernel_nn_skylakex.c:(.text+0x2e1c): undefined reference to `_mm512_reduce_add_pd'
[17:11:19] dgemm_small_kernel_nn_skylakex.c:(.text+0x2e8e): undefined reference to `_mm512_reduce_add_pd'
[17:11:19] dgemm_small_kernel_nn_skylakex.c:(.text+0x2eea): undefined reference to `_mm512_reduce_add_pd'
[17:11:19] dgemm_small_kernel_nn_skylakex.c:(.text+0x30c7): undefined reference to `_mm512_reduce_add_pd'
[17:11:19] ../libopenblas64_p-r0.3.20.a(dgemm_small_kernel_nn_SKYLAKEX.o):dgemm_small_kernel_nn_skylakex.c:(.text+0x3106): more undefined references to `_mm512_reduce_add_pd' follow
[17:11:19] ../libopenblas64_p-r0.3.20.a(sgemm_small_kernel_nn_SKYLAKEX.o): In function `sgemm_small_kernel_nn_SKYLAKEX':
[17:11:19] sgemm_small_kernel_nn_skylakex.c:(.text+0x2ca3): undefined reference to `_mm512_reduce_add_ps'
[17:11:19] sgemm_small_kernel_nn_skylakex.c:(.text+0x2cdc): undefined reference to `_mm512_reduce_add_ps'
[17:11:19] sgemm_small_kernel_nn_skylakex.c:(.text+0x2d42): undefined reference to `_mm512_reduce_add_ps'
[17:11:19] sgemm_small_kernel_nn_skylakex.c:(.text+0x2d95): undefined reference to `_mm512_reduce_add_ps'
[17:11:19] sgemm_small_kernel_nn_skylakex.c:(.text+0x2f25): undefined reference to `_mm512_reduce_add_ps'
[17:11:19] ../libopenblas64_p-r0.3.20.a(sgemm_small_kernel_nn_SKYLAKEX.o):sgemm_small_kernel_nn_skylakex.c:(.text+0x2f5e): more undefined references to `_mm512_reduce_add_ps' follow
[17:11:19] collect2: error: ld returned 1 exit status

OpenMathLib/OpenBLAS#3530 looks relevant, it appears GCC headers in v6 were wrong. This wouldn't even be the first time we hit similar issues when building OpenBLAS, see #2142, #2385, #2389, #2415. Sigh. Edit: for reference, this should be the change which introduced the new intrinsics in GCC: gcc-mirror/gcc@167a5b7

@giordano giordano merged commit 9e2501e into JuliaPackaging:master Feb 23, 2022
@giordano giordano deleted the mg/openblas branch February 23, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
julia 💜 ❤️ 💚 Builders and issues related to Julia and its dependencies linear algebra 🔢
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants