-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build XyceWrapper for Julia v1.11 #7270
Conversation
Also bump to v0.5+
@@ -2,10 +2,10 @@ | |||
# `julia build_tarballs.jl --help` to see a usage message. | |||
using BinaryBuilder, Pkg | |||
|
|||
julia_versions = [v"1.6.3", v"1.7", v"1.8", v"1.9", v"1.10"] | |||
julia_versions = [v"1.7", v"1.8", v"1.9", v"1.10", v"1.11"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also drop 1.6. Intentionally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had trouble when trying to build it for Julia v1.6, so I tried dropping that to see if it would fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in principle nothing should have changed since last successful build, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As usual, I am investigator, victim and perpetrator: https://github.com/JuliaPackaging/Yggdrasil/pull/6180/files
The issue isn't Julia v1.6, it's aarch64
linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have a way to tell BB "filter my own platforms to match this dependency"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to keep the Julia v1.6 exclusion though, just so that I don't have to build a loop over Julia versions here in order to support apple silicon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we'd need JuliaPackaging/BinaryBuilder.jl#639 for that
Note that this is currently building with the new |
And compat entries would probably be good anyway 🙂 |
This PR has not been as smooth as I thought it would be. |
No description provided.