Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build XyceWrapper for Julia v1.11 #7270

Merged
merged 10 commits into from
Aug 31, 2023
Merged

Build XyceWrapper for Julia v1.11 #7270

merged 10 commits into from
Aug 31, 2023

Conversation

staticfloat
Copy link
Member

No description provided.

@@ -2,10 +2,10 @@
# `julia build_tarballs.jl --help` to see a usage message.
using BinaryBuilder, Pkg

julia_versions = [v"1.6.3", v"1.7", v"1.8", v"1.9", v"1.10"]
julia_versions = [v"1.7", v"1.8", v"1.9", v"1.10", v"1.11"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also drop 1.6. Intentionally?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had trouble when trying to build it for Julia v1.6, so I tried dropping that to see if it would fix it.

Copy link
Member

@giordano giordano Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in principle nothing should have changed since last successful build, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual, I am investigator, victim and perpetrator: https://github.com/JuliaPackaging/Yggdrasil/pull/6180/files

The issue isn't Julia v1.6, it's aarch64 linux.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a way to tell BB "filter my own platforms to match this dependency"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to keep the Julia v1.6 exclusion though, just so that I don't have to build a loop over Julia versions here in order to support apple silicon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'd need JuliaPackaging/BinaryBuilder.jl#639 for that

@benlorenz
Copy link
Contributor

Note that this is currently building with the new libcxxwrap_julia_jll version 0.10.0 for which there is no compatible CxxWrap.jl release yet, see #7269 and JuliaInterop/CxxWrap.jl#368. So this might need a compat entry if this is supposed to work with the current CxxWrap release.

@giordano
Copy link
Member

And compat entries would probably be good anyway 🙂

@staticfloat
Copy link
Member Author

This PR has not been as smooth as I thought it would be.

@staticfloat staticfloat merged commit af723c8 into master Aug 31, 2023
@staticfloat staticfloat deleted the sf/xyce_update branch August 31, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants