Dimensionful quantities with Unitful.jl #19
Conversation
|
@crstnbr We can also add some test cases for this one. |
|
What kind of test do you have in mind? The unit printing is implicitly tested by the |
|
Ok, I guess I can write some very basic ones. |
|
@crstnbr Yup, just the basic will work. Wanted to make sure we do have these tested out :) |
|
I'll merge and tag a new v0.1.2 release for this if you approve the changes. |
There was a problem hiding this comment.
LGTM. Are you good to have a new release post this merge? @crstnbr
|
Maybe we should explicitly mention that the fields are dimensionful in the Readme.md as well. Will add this and proceed afterwards. |
|
Sure, makes sense. You can also reply to this comment here once we are good with the release. |
| melt::Float64 | ||
| molar_heat::Float64 | ||
| melt::typeof(1.0K) | ||
| molar_heat::typeof(1.0J/(mol*K)) |
There was a problem hiding this comment.
this reads nice, did not know this works
See #7.
I left the custom unit output as I think
J/mol Kis nicer thanJ mol^-1 K^-1.One could also make this an upstream issue in Unitful.jl and improve the printing of units (PainterQubits/Unitful.jl#18 is similar).