Remove PulseParametrization, use ParametrizedAmplitude instead.
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goerz
added
documentation
goerz
force-pushed
the
pulse-parametrization
branch
from
77bb888 to
1433304
Compare
This removes the old `PulseParametrization` and its initializers `SquareParametrization`, `TanhParametrization`, `TanhSqParametrization`, `LogisticParametrization`, `LogisticSqParametrization`. These have been moved to `QuantumControlBase` in a modified form, see JuliaQuantumControl/QuantumControlBase.jl#46 The parametrization example is updated to use the the new `ParametrizedAmplitude`.
goerz
force-pushed
the
pulse-parametrization
branch
from
1433304 to
369a20e
Compare
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
- Coverage 88.67% 87.92% -0.76%
==========================================
Files 5 4 -1
Lines 265 207 -58
==========================================
- Hits 235 182 -53
+ Misses 30 25 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the old
PulseParametrizationand its initializersSquareParametrization,TanhParametrization,TanhSqParametrization,LogisticParametrization,LogisticSqParametrization.These have been moved to
QuantumControlBasein a modified form, see JuliaQuantumControl/QuantumControlBase.jl#46The parametrization example is updated to use the the new
ParametrizedAmplitude.