Add generalized evaluate, substitute
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `eval_controls` → `evaluate` and generalize such that `evaluate` evaluates arbitrary time-dependent objects to static objects. The `vals_dict` parameter for plugging in values for the controls is now an optional keyword argument. Without it, the controls are simply evaluated for the point in time specified by the positional arguments. Also, rename `substitute_controls` → `substitute`. This can now substitute a wide range of objects. One application this opens up is to substitute controls with parametrized amplitudes.
goerz
force-pushed
the
evaluate-substitute
branch
from
fce42d5 to
5d0fd16
Compare
goerz
added a commit
to JuliaQuantumControl/QuantumControlBase.jl
that referenced
this pull request
Nov 17, 2022
goerz
added a commit
to JuliaQuantumControl/Krotov.jl
that referenced
this pull request
Nov 17, 2022
goerz
added a commit
to JuliaQuantumControl/GRAPE.jl
that referenced
this pull request
Nov 17, 2022
goerz
added a commit
to JuliaQuantumControl/QuantumControl.jl
that referenced
this pull request
Nov 17, 2022
goerz
added a commit
to JuliaQuantumControl/QuantumControlBase.jl
that referenced
this pull request
Nov 18, 2022
goerz
added a commit
to JuliaQuantumControl/Krotov.jl
that referenced
this pull request
Nov 18, 2022
goerz
added a commit
to JuliaQuantumControl/GRAPE.jl
that referenced
this pull request
Nov 18, 2022
goerz
added a commit
to JuliaQuantumControl/QuantumControl.jl
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
eval_controls→evaluateand generalize such thatevaluateevaluates arbitrary time-dependent objects to static objects. Thevals_dictparameter for plugging in values for the controls is now an optional keyword argument. Without it, the controls are simply evaluated for the point in time specified by the positional arguments.Also, rename
substitute_controls→substitute. This can now substitute a wide range of objects. One application this opens up is to substitute controls with parametrized amplitudes.