Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugs in transitions.jl #311

Merged
merged 1 commit into from
Aug 23, 2020
Merged

bugs in transitions.jl #311

merged 1 commit into from
Aug 23, 2020

Conversation

dfcaporale
Copy link
Member

Fix bugs in transitions.jl. Nevertheless, it seems Polyhedra and CDDLib are required to compute linear_map with elimination.

@mforets
Copy link
Member

mforets commented Aug 23, 2020

Fix bugs in transitions.jl.

thanks!

Nevertheless, it seems Polyhedra and CDDLib are required to compute linear_map with elimination.

yes; that method uses Fourier-Motzkin elimination and it's available from Polyhedra.eliminate. the reason to opt for letting such libraries be optional is that for set based computations we can (and should) often workaround computing with concrete polyhedra which is usually expensive.

@mforets mforets merged commit 65ab614 into master Aug 23, 2020
@mforets mforets deleted the dfcaporale/Hybrid_transitions branch August 23, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfcaporale @mforets