Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External kwarg to TMJets solver #326

Merged
merged 2 commits into from
Sep 4, 2020
Merged

External kwarg to TMJets solver #326

merged 2 commits into from
Sep 4, 2020

Conversation

mforets
Copy link
Member

@mforets mforets commented Sep 3, 2020

With this PR we can call TMJets with an external solver from TaylorModels using the external=true flag. Pass a solver_name to specify using a function different than validated_integ.

cc: @UzielLinares

@mforets mforets changed the title add external (WIP) External kwarg to TMJets solver Sep 4, 2020
@mforets
Copy link
Member Author

mforets commented Sep 4, 2020

@UzielLinares, @lbenet this is ready from my side. see an example notebook here. more proper docs and testing can come in a follow up pr.

note that you can pass

  • external=true (required to use a solver different than the one in src/Algorithms/TMJets/reach.jl
  • solver_name (optional) if you want to pass a function name which is different than TaylorModels.validated_integ
  • solver_kwargs (optional) if you want to pass additional keyword arguments to the solver function

@ulinares
Copy link

ulinares commented Sep 4, 2020

Looks great! I'll check out.

@lbenet
Copy link
Collaborator

lbenet commented Sep 4, 2020

Thanks a lot!

@mforets mforets merged commit 3bd6374 into master Sep 4, 2020
@mforets mforets deleted the mforets/tmjets_ext branch September 4, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants