Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compat for TM and other packages #621

Merged
merged 4 commits into from
Apr 25, 2022
Merged

Bump compat for TM and other packages #621

merged 4 commits into from
Apr 25, 2022

Conversation

schillic
Copy link
Member

@schillic schillic commented Apr 20, 2022

This combines #619 and #620.

Currently there are errors with TMJets20 (TMJets21a and TMJets21b work).

@mforets mforets marked this pull request as ready for review April 22, 2022 19:07
@schillic schillic changed the title Bump compat for packages Bump compat for TM and other packages Apr 22, 2022
@schillic
Copy link
Member Author

There is an error with a model where in the @taylorize the variable t is used both as a function argument and as an internal variable. A simplified example:

julia> @taylorize function f!(du, u, p, t)
           x, t = u
           return du
       end
ERROR: syntax: "__tmpTaylor[2]" is not a valid function argument name around ~/.julia/packages/TaylorIntegration/RHhYj/src/parse_eqs.jl:1075

This is fixed by using a different variable name:

julia> @taylorize function f!(du, u, p, t)
           x, t2 = u
           return du
       end

We should change the model anyway for clarity, but @lbenet FYI that this worked before.

@lbenet
Copy link
Collaborator

lbenet commented Apr 24, 2022

Thanks for reporting @schillic! I've opened PerezHz/TaylorIntegration.jl#143 to keep it in mind.

In any case, I think it is sane to have another variable for the dependent variables, u[2] in your example, even when it corresponds to the independent variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants