Integrate with Flowstar.jl #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agerlach
reviewed
Jun 23, 2022
Co-authored-by: agerlach <[email protected]>
agerlach
reviewed
Jun 24, 2022
|
I think this is good as a first iteration; we can incorporate the commented test in another PR. |
|
Ok in the last commit I've added the code for model generation. I'm getting an error, not sure if this is related to a corrupt model or sth else. |
|
Should be fixed now. From my side this is ready to merge. |
agerlach
reviewed
Jun 27, 2022
|
Looks good to me |
|
I got this error when trying to register the new version of RA: #111 (comment) |
This should be fixed now because the package got released. Maybe we should require v0.2.4 as the minimum version, but otherwise please try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #640.