Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an error when using
GLGM06
with hybrid systems because we do not allow to not intersect with the source invariant anymore (nothing
is not a valid parameter anymore because of the restriction toAbstractIntersectionMethod
)ReachabilityAnalysis.jl/src/Hybrid/solve.jl
Line 12 in 1456c39
ReachabilityAnalysis.jl/src/Hybrid/solve.jl
Lines 25 to 27 in 1456c39
This means that the
else
branch below is effectively dead code:ReachabilityAnalysis.jl/src/Hybrid/solve.jl
Lines 251 to 256 in 1456c39
That lead to the bouncing ball failing because
X0
is converted to anHPolytope
, which the discretization cannot deal with. One problem is thatdiscretize
did not print any error because it just uses the no-op default method. I now changed the code to at least print an error message if the discretization failed.There is a similar error in
faq.md
(which is why the last code block here is not executed). But I did not investigate if we still have an algorithm to support aConvexHullArray
.