Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reset_map methods #697

Merged
merged 2 commits into from
May 7, 2023
Merged

Remove reset_map methods #697

merged 2 commits into from
May 7, 2023

Conversation

schillic
Copy link
Member

@schillic schillic commented May 6, 2023

The first method below does not have the right number of arguments (ConstrainedAffineMap takes three arguments):

reset_map(tr::DiscreteTransition{<:AbstractMatrix}) = ConstrainedAffineMap(tr.R, tr.W)
reset_map(tr::DiscreteTransition{<:IdentityMap}) = ConstrainedIdentityMap(dim(tr.W), tr.W)

I tried to come up with a fix but found that I am generally in doubt about the semantics of reset_map. Given that the first method should throw an error, it seems to not be used. I suggest we remove them.

@schillic schillic marked this pull request as ready for review May 6, 2023 11:35
@mforets mforets merged commit 6cbff5a into master May 7, 2023
@mforets mforets deleted the schillic/reset_map branch May 7, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants