Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: HerbCore v0.3.0 #105605

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

JuliaRegistrator
Copy link
Contributor

## Added

- Code coverage for testing and reporting on Codecov
- `JuliaFormatter` support and CI workflow to enforce style on PRs
- CI workflow for checking that documentation builds
- `AbstractHole` and `AbstractUniformHole` types to support multiple (uniform) `Hole` types
- `AbstractConstraint` to support multiple constraint types
- `UniformHole` for holes where all rules in the domain have the same child types.
- `get_path(...)` to find a path between two `RuleNodes` in a tree if one exists
- `number_of_holes(...)`, `contains_nonuniform_hole(...)`, `get_children(...)`, `get_rule(...)`, `isuniform(...)`, `isfilled(...)`, `hasdynamicvalue(...)`, `have_same_shape(...)`

## Changed

- All methods that previously were typed for the concrete `Hole` now use the `AbstractHole`
- `RuleNode`-related methods (like `Base.isless`) updated to use `AbstractRuleNodes` to support a larger part of the type tree (`Hole`s, etc.) rather than only `RuleNode`s

UUID: 2b23ba43-8213-43cb-b5ea-38c12b45bd45
Repo: https://github.com/Herb-AI/HerbCore.jl.git
Tree: 923877c2715b8166d7ba9f9be2136d70eed87725

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@JuliaTagBot JuliaTagBot merged commit f2f406c into master Apr 25, 2024
22 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-herbcore-2b23ba43-v0.3.0-4a2029218f branch April 25, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants