This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
Remove solvers from SuiteSparse.jl #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I doubt tests will pass here until the other PR is finished. |
|
@KristofferC does this look right then? If so am I good to merge both? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion to JuliaSparse/SparseArrays.jl#95, which aims to fix dependency problems with
using SparseArraysandLinearAlgebraasSparseArrays.jlandSuiteSparse.jlare removed from the sysimage.I aimed to exactly match the current API through use of const aliases, allowing for downstream users to avoid breakage while we deprecate this package.
I propose that SuiteSparse.jl be deprecated over time, and existing solvers be maintained in SparseArrays.jl.
Eventually I think it's ideal for solvers to be independent again, in user-level packages (CHOLMOD.jl), but for now bundling maintains compatibility.