Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statically Compiled E-Matcher #199

Merged
merged 18 commits into from
Apr 28, 2024
Merged

Statically Compiled E-Matcher #199

merged 18 commits into from
Apr 28, 2024

Conversation

0x0f0f0f
Copy link
Member

@0x0f0f0f 0x0f0f0f commented Apr 21, 2024

No description provided.

@0x0f0f0f 0x0f0f0f changed the base branch from master to ale/3.0 April 21, 2024 17:30
@0x0f0f0f 0x0f0f0f changed the base branch from ale/3.0 to master April 28, 2024 13:32
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.76063% with 172 lines in your changes are missing coverage. Please review.

Project coverage is 72.95%. Comparing base (a8331d6) to head (6ce74d5).
Report is 2 commits behind head on master.

Files Patch % Lines
src/EGraphs/egraph.jl 79.90% 44 Missing ⚠️
src/ematch_compiler.jl 0.00% 43 Missing ⚠️
src/EGraphs/saturation.jl 80.51% 30 Missing ⚠️
src/Patterns.jl 74.35% 10 Missing ⚠️
src/ematch_compiler_new.jl 95.03% 8 Missing ⚠️
ext/Plotting.jl 0.00% 6 Missing ⚠️
src/Rewriters.jl 53.84% 6 Missing ⚠️
src/Rules.jl 66.66% 6 Missing ⚠️
src/Syntax.jl 86.66% 6 Missing ⚠️
src/matchers.jl 89.47% 4 Missing ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   69.17%   72.95%   +3.77%     
==========================================
  Files          16       19       +3     
  Lines        1353     1427      +74     
==========================================
+ Hits          936     1041     +105     
+ Misses        417      386      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark Results

master 6ce74d5... master/6ce74d5c9f603b...
basic_maths/simpl1 0.0561 ± 0.0043 s 17 ± 0.99 ms 3.3
calc_logic/demorgan 0.594 ± 0.013 ms 0.204 ± 0.0042 ms 2.92
egraph/addexpr 19.3 ± 1.8 ms 6.87 ± 0.26 ms 2.81
egraph/constructor 0.591 ± 0.027 μs 0.679 ± 0.036 μs 0.871
prop_logic/demorgan 0.954 ± 0.02 ms 0.24 ± 0.0044 ms 3.97
prop_logic/freges_theorem 0.0399 ± 0.0035 s 9.18 ± 0.16 ms 4.35
prop_logic/prove1 9.37 s 0.0916 ± 0.0027 s 102
prop_logic/rewrite 0.0759 ± 0.0016 ms 0.048 ± 0.0014 ms 1.58
while_superinterpreter/while_10 0.123 ± 0.00079 s 0.0326 ± 0.0019 s 3.76
time_to_load 0.26 ± 0.0054 s 0.154 ± 0.00061 s 1.68

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@0x0f0f0f 0x0f0f0f changed the base branch from master to ale/3.0 April 28, 2024 14:11
@0x0f0f0f 0x0f0f0f merged commit 895cf6c into ale/3.0 Apr 28, 2024
0x0f0f0f added a commit that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants