Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hash collisions in e-graph saturation #229

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Fix hash collisions in e-graph saturation #229

merged 1 commit into from
Jul 6, 2024

Conversation

gkronber
Copy link
Collaborator

@gkronber gkronber commented Jul 5, 2024

Fix hash collision in EGraph.memo by changing the dictionary key to VecExpr. Create struct for VecExpr and wrap Vector{Id}.

@gkronber
Squashed commit of the following:
32be369 
commit 0fd0c91
Author: Gabriel Kronberger <[email protected]>
Date:   Wed Jul 3 20:47:25 2024 +0200

    Create struct for VecExpr and wrap Vector{Id}.

commit a37b576
Author: Gabriel Kronberger <[email protected]>
Date:   Wed Jul 3 11:37:51 2024 +0200

    Fix for quickfix

commit 764540c
Author: Gabriel Kronberger <[email protected]>
Date:   Wed Jul 3 11:34:32 2024 +0200

    Quick fix for hash collision
@gkronber
Copy link
Collaborator Author

gkronber commented Jul 5, 2024

#225

@gkronber gkronber changed the title Squashed commit of the following: Fix hash collisions in e-graph saturation Jul 5, 2024
@0x0f0f0f 0x0f0f0f merged commit d10173c into JuliaSymbolics:ale/3.0 Jul 6, 2024
@0x0f0f0f
Copy link
Member

0x0f0f0f commented Jul 6, 2024

Thanks!!!

@gkronber gkronber mentioned this pull request Aug 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkronber @0x0f0f0f