-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lambda theory test #236
Fix lambda theory test #236
Conversation
…nts of eclasses for which the semantic value has changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0x0f0f0f for what it's worth, I read through this bug fix and it seems correct to me, at least with respect to my understanding as captured in this comment:
Metatheory.jl/src/EGraphs/egraph.jl
Lines 77 to 85 in 107da67
""" | |
merge_analysis_data!(a::EClass{D}, b::EClass{D})::Tuple{Bool,Bool,Union{D,Nothing}} where {D} | |
Returns a tuple of: `(did_update_a, did_update_b, newdata)` where: | |
- `did_update_a` is a boolean indicating whether `a`'s analysis class was updated | |
- `did_update_b` is a boolean indicating whether `b`'s analysis class was updated | |
- `newdata` is the merged analysis data | |
""" |
In retrospect, if I had paid more attention while writing that comment, I could have caught this...
Let me add a few more test assertions to check the free variable analysis before merging this. |
Nice, can you trigger CI here as well pleae? |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## ale/3.0 #236 +/- ##
==========================================
Coverage ? 80.78%
==========================================
Files ? 19
Lines ? 1504
Branches ? 0
==========================================
Hits ? 1215
Misses ? 289
Partials ? 0 ☔ View full report in Codecov by Sentry. |
@gkronber ok to merge? |
PR for #235.
Fixes semantic analysis code for lambda theory test case and a bug which caused missing updates of parent eclasses after the semantic value of an eclass was changed.