3.0 minor fixes and improvements

[gkronber]

No description provided.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.59430% with 148 lines in your changes missing coverage. Please review.

Please upload report for BASE (ale/3.0@8e95e4a). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/EGraphs/Schedulers.jl	43.47%	26 Missing ⚠️
src/utils.jl	7.69%	24 Missing ⚠️
src/EGraphs/egraph.jl	89.63%	23 Missing ⚠️
src/Syntax.jl	89.33%	16 Missing ⚠️
src/Patterns.jl	74.46%	12 Missing ⚠️
src/EGraphs/saturation.jl	95.20%	7 Missing ⚠️
src/Rules.jl	83.33%	7 Missing ⚠️
ext/Plotting.jl	0.00%	6 Missing ⚠️
src/Rewriters.jl	53.84%	6 Missing ⚠️
src/ematch_compiler.jl	95.83%	6 Missing ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             ale/3.0     #243   +/-   ##
==========================================
  Coverage           ?   81.17%           
==========================================
  Files              ?       19           
  Lines              ?     1503           
  Branches           ?        0           
==========================================
  Hits               ?     1220           
  Misses             ?      283           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark Results

	egg-sym	egg-cust	MT@3373cb64951...	MT@0b2e6c9f11b...	egg-sym/MT@337...	egg-cust/MT@33...	MT@0b2e6c9f11b...
egraph_addexpr	1.46 ms		5 ms	4.99 ms	0.292		0.999
basic_maths_simpl2	13.6 ms	4.95 ms	19.9 ms	20.7 ms	0.682	0.248	1.04
prop_logic_freges_theorem	2.53 ms	1.55 ms	1.06 ms	1.07 ms	2.38	1.46	1.01
calc_logic_demorgan	60.9 μs	35.8 μs	77.4 μs	77.4 μs	0.786	0.463	0.999
calc_logic_freges_theorem	21.9 ms	12.3 ms	42 ms	42.6 ms	0.521	0.292	1.02
basic_maths_simpl1	6.36 ms	2.8 ms	4.68 ms	4.77 ms	1.36	0.599	1.02
egraph_constructor	0.0826 μs		0.0916 μs	0.0923 μs	0.902		1.01
prop_logic_prove1	35.3 ms	13.3 ms	42.1 ms	43 ms	0.839	0.316	1.02
prop_logic_demorgan	80.1 μs	45.6 μs	95.5 μs	98.2 μs	0.839	0.478	1.03
while_superinterpreter_while_10			18.5 ms	18.7 ms			1.01
prop_logic_rewrite			120 μs	121 μs			1.01
time_to_load			507 ms	502 ms			0.99

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

[0x0f0f0f]

LGTM

[0x0f0f0f]

@gkronber you can mark as ready i guess

[gkronber]

I'll leave this open for a few more days for a few more smaller changes

[gkronber]

@0x0f0f0f should I merge back to ale/3.0, or do you prefer to continue to be responsible for merges?

[0x0f0f0f]

@0x0f0f0f should I merge back to ale/3.0, or do you prefer to continue to be responsible for merges?

@gkronber i prefer still having a final look at the PRs if possible :)