Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MU-puzzle rules and add more tests from original source. #247

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

gkronber
Copy link
Collaborator

Proposed fix for #240.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (79c1a7b) to head (22a10f3).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           ale/3.0     #247   +/-   ##
========================================
  Coverage    81.06%   81.06%           
========================================
  Files           19       19           
  Lines         1500     1500           
========================================
  Hits          1216     1216           
  Misses         284      284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark Results

egg-sym egg-cust MT@22a10f3e7bf... MT@79c1a7b9ae2... egg-sym/MT@22a... egg-cust/MT@22... MT@79c1a7b9ae2...
egraph_addexpr 1.44 ms 5.1 ms 5.09 ms 0.283 0.998
basic_maths_simpl2 12.5 ms 4.97 ms 20 ms 20.2 ms 0.626 0.248 1.01
prop_logic_freges_theorem 2.51 ms 1.55 ms 1.06 ms 1.07 ms 2.38 1.47 1.01
calc_logic_demorgan 60.4 μs 35.5 μs 76.5 μs 78.4 μs 0.789 0.464 1.02
calc_logic_freges_theorem 22.1 ms 12.3 ms 41.8 ms 43.3 ms 0.528 0.294 1.04
basic_maths_simpl1 5.99 ms 2.78 ms 4.68 ms 4.72 ms 1.28 0.594 1.01
egraph_constructor 0.0851 μs 0.0932 μs 0.0916 μs 0.913 0.982
prop_logic_prove1 35.3 ms 13.9 ms 41.7 ms 41.7 ms 0.846 0.334 1
prop_logic_demorgan 79.2 μs 44.8 μs 95.4 μs 97.6 μs 0.83 0.469 1.02
while_superinterpreter_while_10 18.2 ms 18.5 ms 1.02
prop_logic_rewrite 120 μs 120 μs 0.998
time_to_load 506 ms 507 ms 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@gkronber gkronber marked this pull request as ready for review September 14, 2024 07:22
@0x0f0f0f 0x0f0f0f merged commit dab995c into ale/3.0 Sep 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants