Fix: Consider metadata in BasicSymbolic isequal

JuliaSymbolics · Nov 4, 2024 · 1bce8ae · 1bce8ae
1 parent f9b0ade
commit 1bce8ae
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/types.jl b/src/types.jl
@@ -245,6 +245,7 @@ function Base.isequal(a::BasicSymbolic{T}, b::BasicSymbolic{S}) where {T,S}
     E === exprtype(b) || return false
 
     T === S || return false
+    isequal(metadata(a), metadata(b)) || return false
     return _isequal(a, b, E)::Bool
 end
 function _isequal(a, b, E)

diff --git a/test/basics.jl b/test/basics.jl
@@ -336,6 +336,13 @@ end
 
     @test !isequal(a, missing)
     @test !isequal(missing, b)
+
+    a1 = setmetadata(a, Ctx1, "meta_1")
+    a2 = setmetadata(a, Ctx1, "meta_1")
+    a3 = setmetadata(a, Ctx2, "meta_2")
+    @test !isequal(a, a1)
+    @test isequal(a1, a2)
+    @test !isequal(a1, a3)
 end
 
 @testset "subtyping" begin