Metadata of Term changes in substitution

[hexaeder]

using SymbolicUtils
using SymbolicUtils: Term
@syms a b f t
f = Term(f, (t,)) # create term f(t)
f = setmetadata(f, Bool, true)
hasmetadata(f, Bool) # true
newf = substitute(f, Dict(a=>b)) # unrelated substitution
hasmetadata(newf, Bool) # false

I think this is a M(not)WE for SymbolicUtils. The problem came up after recent changes to MTK SciML/ModelingToolkit.jl/pull/943

using ModelingToolkit
using ModelingToolkit: isparameter
@parameters t a(t)
@variables x(t) y(t)
isparameter(a) # true
isparameter(substitute(a, x=>y)) # false :(

[shashi]

Oh I see... I think we should use similarterm in substitute and it should carry forward metadata of the "reference" term... via a kwarg so that it can be overloaded. cc @YingboMa