Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix substitute when using metadata #284

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Fix substitute when using metadata #284

merged 2 commits into from
Apr 20, 2021

Conversation

shashi
Copy link
Member

@shashi shashi commented Apr 19, 2021

fixes #283

@shashi shashi requested a review from YingboMa April 19, 2021 15:13
adamslc
adamslc requested changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@adamslc adamslc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo to fix.

src/types.jl Outdated Show resolved Hide resolved
@shashi @adamslc
Update src/types.jl
78dfcb0 
Co-authored-by: Luke Adams <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #284 (78dfcb0) into master (0d2f6b7) will decrease coverage by 0.06%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
- Coverage   85.86%   85.79%   -0.07%     
==========================================
  Files          12       12              
  Lines        1174     1176       +2     
==========================================
+ Hits         1008     1009       +1     
- Misses        166      167       +1
Impacted Files Coverage Δ
src/types.jl 89.17% <81.81%> (-0.19%) ⬇️
src/api.jl 91.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2f6b7...78dfcb0. Read the comment docs.

@shashi
Copy link
Member Author

shashi commented Apr 20, 2021

@adamslc thanks!

@shashi shashi merged commit 72516d2 into master Apr 20, 2021
@shashi shashi deleted the s/fix-substitute-metadata branch April 20, 2021 02:10
@hexaeder hexaeder mentioned this pull request Feb 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamslc adamslc adamslc requested changes

@YingboMa YingboMa YingboMa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metadata of Term changes in substitution
4 participants
@shashi @codecov-commenter @YingboMa @adamslc