Removing DataStructures 0.17 from Project.toml #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasonProtter
approved these changes
Nov 19, 2020
|
i meant to ask earlier: the add and rm of the Manifest (while not huge) is junk in the tree is there something that can be done to merge the commits? is this non-issue? thanks |
|
Yeah, generally, people shouldn't include the manifest in a package without a very good reason to include it (needing exact reproducibility). I think this is a benign enough change that it's okay for me to merge without waiting, so I'll do that but if @shashi disapproves we can undo it in the morning. |
|
Looks good, thanks! Usually CompatHelper should get this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing SymbolicUtils caused a good deal of version conflicts for me, I believe this is because of DataStructures 0.17
All tests passed on my fork, so I think they will pass on this PR.
Thanks!