-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small page/manual link fixes #221
Small page/manual link fixes #221
Conversation
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
==========================================
- Coverage 86.10% 86.00% -0.11%
==========================================
Files 12 12
Lines 993 993
==========================================
- Hits 855 854 -1
- Misses 138 139 +1
Continue to review full report at Codecov.
|
WIP: I've found some more breaks within the pages/manual due to associativity-commutativity (AC) rules being default now: Please treat this PR as WIP.
|
Thanks, these are awesome fixes! Those broken examples are a bit of a good problem :-p the simplifications happen automatically. But we should fix it! It's my bad for not keeping an eye on them. |
I can try to fix the examples and come up with the new (hopefully adequate) ones if that's okay with you. :) If yes should this be a part of this PR or should I create a new one and limit this one to just fixes of the links? |
Of course, thank you!! In this PR is fine! |
Maybe we should just merge this one in the meantime and open a new PR for the example so these problems get fixed ASAP. Are the test failures real? I don't see how this could break DataDrivenDiffEq or ModelingToolkit. I'll just re-run the tests. |
Sure, by all means merge as it is. Fixing manual takes a bit more time than I thought and I'll do it in separate PR. I have no idea why the test fail. I didn't touch anything related to tests. |
I've almost fixed listed problems. I nearly finished Getting Started and Term Rewriting sections. Only two things left. I'll open a PR tomorrow (actually later today where I live). Haven't looked into Interfacing, Code generation and API Reference sections yet but they may be left for further PR if you prefer to fix examples ASAP. |
Those downstream issues were some versioning things we fixed over the last day. |
Hi, I've decided to try to do something useful as I was going through manual 😃
I fixed the links in the readme and at the index page of the manual (they didn't work). I also changed links from
juliasymbolics.github.io/SymbolicUtils.jl
tohttps://symbolicutils.juliasymbolics.org
. Not sure whether it's the right way. I see the pages are inPkgPage.jl
and it said to edit index.md directly.I think it will be easier for first time contributors (such as me) if it was written what are the docs/pages built in. It says "Website built with Franklin.jl." at the bottom of the page, but I've found that PkgPage.jl is used only after looking at CI and gh-pages branch. So I added PkgPage.jl with link to "Website built with..." part in the footer.