Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make number methods defined only on Symbolic{<:Number} #259

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Conversation

shashi
Copy link
Member

@shashi shashi commented Mar 30, 2021

This is good for everyone's health.

Co-authored-by: "Yingbo Ma" <mayingbo5@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #259 (f100b5e) into master (142ea18) will not change coverage.
The diff coverage is 40.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   86.28%   86.28%           
=======================================
  Files          11       11           
  Lines        1108     1108           
=======================================
  Hits          956      956           
  Misses        152      152           
Impacted Files Coverage Δ
src/types.jl 88.72% <ø> (ø)
src/methods.jl 86.11% <40.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddef8dc...f100b5e. Read the comment docs.

@shashi shashi merged commit a8523b8 into master Mar 30, 2021
@shashi shashi deleted the s/num-methods branch March 30, 2021 09:44
@shashi shashi mentioned this pull request Aug 5, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants