-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend and document canonical form of Symbolic{<:Number}
#266
Extend and document canonical form of Symbolic{<:Number}
#266
Conversation
As I saw when writing this docs, there are things that can be done to further improve the canonical form just using I can contribute these this week, but I don't know if put them in this PR or make another with "just the code". If is needed in another PR i would extend the docs here to reflect the changes made in the other PR. I also don't know if I should add here in the docs the optimizations for some functions (as in 262) or not, and all the "basic" operators |
What do you mean by this? What are the changes you're planning to make? Feel free to put them in this PR! :) |
In master now you have that julia> x*inv(x)
1 For some julia> (x^-1)*inv(x^-1)
(x^-1)*((x^-1)^-1) And you can see why this is happening julia> print_tree((x^-1)*inv(x^-1))
*
├─ 1
├─ (^)
│ ├─ x
│ └─ -1
└─ (^)
├─ ^
│ ├─ x
│ └─ -1
└─ -1 Basically |
I found what it is happening, the |
Now with this PR, aside the documentation julia> (x^-1)*inv(x^-1)
1 Still needs to finish the documentation part. |
Symbolic{<:Number}
Symbolic{<:Number}
Could you add a test for SymbolicUtils.jl/test/basics.jl Line 187 in 491ad80
|
Yeah, sure. I finished adding the documentation. And I added the test. |
Locally all the test passed 😄, now to the next issue. 😛 |
fix #256