Perf #3

YingboMa · 2020-02-12T04:36:41Z

julia> using SymbolicUtils

julia> @vars a b c;

julia> x = foldr(*, [rand([a, b, c]) for i in 1:1000]);

julia> r = rewriter(SymbolicUtils.PLUS_AND_SCALAR_MUL);

julia> r(x);

julia> @time r(x);
  1.664081 seconds (19.56 M allocations: 1.992 GiB, 6.34% gc time)

@vars

```julia julia> using SymbolicUtils julia> @vars a b c; julia> x = foldr(*, [rand([a, b, c]) for i in 1:1000]); julia> r = rewriter(SymbolicUtils.PLUS_AND_SCALAR_MUL); julia> r(x); julia> @time r(x); 0.019116 seconds (250.73 k allocations: 23.153 MiB, 29.31% gc time) ```

shashi · 2020-02-12T04:48:03Z

src/util.jl

-end
+@inline cdr(v) = isempty(v) ? empty(l) : LL(v, 2)
+
+@inline take_n(ll::LL, n) = isempty(ll) || n == 0 ? empty(ll) : @view ll.v[ll.i:min(end, n+ll.i-1)]


maybe LL{<:AbstractVector}? it can be anything.

shashi · 2020-02-12T04:48:46Z

src/util.jl

+@inline cdr(v) = isempty(v) ? empty(l) : LL(v, 2)
+
+@inline take_n(ll::LL, n) = isempty(ll) || n == 0 ? empty(ll) : @view ll.v[ll.i:min(end, n+ll.i-1)]
+@inline take_n(ll, n) = @view ll[1:min(end, n)]


This should probably fail if it can't take. The only place it is used shouldn't need it to fail silently.

~~I think we actually need this.~~

I'm saying @view ll[1:min(end, n)] should be @view ll[1:n]

shashi · 2020-02-12T04:55:25Z

src/util.jl

@@ -6,27 +6,27 @@ end
 islist(::Any) = false
 islist(l::Union{LL, Term, AbstractArray, Tuple}) = true

+Base.empty(l::LL) = empty(l.v)


I didn't know about this function, so type stable, wow.

YingboMa · 2020-02-12T05:03:25Z

Oh, don't merge this. It is wrong.

shashi · 2020-02-12T05:08:56Z

src/util.jl


+@inline drop_n(ll::Term, n) = drop_n(arguments(ll), n)
+@inline drop_n(ll::AbstractArray, n) = drop_n(LL(ll, 1), n)
+@inline drop_n(ll::LL, n) = LL(ll.v, max(1, ll.i-n))


I think it needs to handle ll.i-n=0, otherwise segment recognition is wrong.

shashi · 2020-02-12T05:09:44Z

src/util.jl


+@inline drop_n(ll::Term, n) = drop_n(arguments(ll), n)


should be drop_n(arguments(ll), n-1)

f is considered car of a term

Co-authored-by: "Shashi Gowda" <[email protected]> Co-authored-by: "Yingbo Ma" <[email protected]>

Perf

7af94bc

```julia julia> using SymbolicUtils julia> @vars a b c; julia> x = foldr(*, [rand([a, b, c]) for i in 1:1000]); julia> r = rewriter(SymbolicUtils.PLUS_AND_SCALAR_MUL); julia> r(x); julia> @time r(x); 0.019116 seconds (250.73 k allocations: 23.153 MiB, 29.31% gc time) ```

YingboMa requested a review from shashi February 12, 2020 04:36

shashi reviewed Feb 12, 2020

View reviewed changes

Make take_n and drop_n more generic

ca86809

shashi reviewed Feb 12, 2020

View reviewed changes

YingboMa force-pushed the myb/perf branch from bfcc695 to 0e348e8 Compare February 12, 2020 05:18

Fix drop_n

93f4337

Co-authored-by: "Shashi Gowda" <[email protected]> Co-authored-by: "Yingbo Ma" <[email protected]>

YingboMa force-pushed the myb/perf branch from 0e348e8 to 93f4337 Compare February 12, 2020 05:21

shashi merged commit 208fd32 into master Feb 12, 2020

shashi deleted the myb/perf branch February 12, 2020 05:28

abrombo mentioned this pull request Aug 17, 2024

Simplifcation of Expression Containing Trig Function #633

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Perf #3

Perf #3

YingboMa commented Feb 12, 2020 •

edited

Loading

shashi Feb 12, 2020

shashi Feb 12, 2020

YingboMa Feb 12, 2020 •

edited

Loading

shashi Feb 12, 2020

shashi Feb 12, 2020

YingboMa commented Feb 12, 2020

shashi Feb 12, 2020 •

edited

Loading

shashi Feb 12, 2020

Perf #3

Perf #3

Conversation

YingboMa commented Feb 12, 2020 • edited Loading

shashi Feb 12, 2020

Choose a reason for hiding this comment

shashi Feb 12, 2020

Choose a reason for hiding this comment

YingboMa Feb 12, 2020 • edited Loading

Choose a reason for hiding this comment

shashi Feb 12, 2020

Choose a reason for hiding this comment

shashi Feb 12, 2020

Choose a reason for hiding this comment

YingboMa commented Feb 12, 2020

shashi Feb 12, 2020 • edited Loading

Choose a reason for hiding this comment

shashi Feb 12, 2020

Choose a reason for hiding this comment

YingboMa commented Feb 12, 2020 •

edited

Loading

YingboMa Feb 12, 2020 •

edited

Loading

shashi Feb 12, 2020 •

edited

Loading