Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplifying Pow of Div + test #373

Merged
merged 6 commits into from
Jun 15, 2022

Conversation

jkosata
Copy link
Contributor

@jkosata jkosata commented Sep 22, 2021

Fixes #372

src/polyform.jl Outdated Show resolved Hide resolved
src/polyform.jl Outdated Show resolved Hide resolved
@shashi
Copy link
Member

shashi commented Sep 24, 2021

Thanks for taking this on :) This is great!

@codecov-commenter
Copy link

Codecov Report

Merging #373 (6554db8) into master (95ddcce) will decrease coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
- Coverage   83.82%   83.57%   -0.26%     
==========================================
  Files          12       12              
  Lines        1465     1467       +2     
==========================================
- Hits         1228     1226       -2     
- Misses        237      241       +4     
Impacted Files Coverage Δ
src/polyform.jl 92.82% <100.00%> (-1.30%) ⬇️
src/code.jl 80.55% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95ddcce...6554db8. Read the comment docs.

@jkosata jkosata requested a review from shashi September 30, 2021 09:51
@etiennedeg
Copy link

Is there a reason why it is not merged yet? I'm really hoping to see this issue fixed.

@shashi shashi merged commit c109aa2 into JuliaSymbolics:master Jun 15, 2022
@shashi
Copy link
Member

shashi commented Jun 15, 2022

@etiennedeg thanks for the bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simplify_fractions misses powers of fractions
4 participants