Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ordering for types #413

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Conversation

gronniger
Copy link
Contributor

@gronniger gronniger commented Dec 25, 2021

This is required to make all tests in JuliaSymbolics/Symbolics.jl#483 work.

@codecov-commenter
Copy link

Codecov Report

Merging #413 (085565e) into master (22778bb) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #413      +/-   ##
==========================================
- Coverage   83.81%   83.75%   -0.07%     
==========================================
  Files          12       12              
  Lines        1359     1360       +1     
==========================================
  Hits         1139     1139              
- Misses        220      221       +1     
Impacted Files Coverage Δ
src/ordering.jl 88.50% <0.00%> (+0.13%) ⬆️
src/polyform.jl 93.44% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22778bb...085565e. Read the comment docs.

@YingboMa YingboMa requested a review from shashi January 20, 2022 18:00
@shashi shashi merged commit e2a6f8a into JuliaSymbolics:master Jan 24, 2022
@shashi
Copy link
Member

shashi commented Jan 24, 2022

Would be nice to have a test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants