-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjoint(y::Symbolic{<:Number}) #635
adjoint(y::Symbolic{<:Number}) #635
Conversation
…:Symbolic{Number}) method; tests for real and complex syms
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Could you add some tests?
Yes, I added tests for Real and Complex syms. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #635 +/- ##
==========================================
+ Coverage 81.86% 81.92% +0.06%
==========================================
Files 16 16
Lines 1908 1909 +1
==========================================
+ Hits 1562 1564 +2
+ Misses 346 345 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! |
I added the method
adjoint(y::Symbolic{<:Number}) = conj(s)
.This is what Julia does for example with
adjoint(1im)
.