Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjoint(y::Symbolic{<:Number}) #635

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

ChristophHotter
Copy link
Contributor

I added the method adjoint(y::Symbolic{<:Number}) = conj(s).
This is what Julia does for example with adjoint(1im).

Copy link
Contributor

github-actions bot commented Aug 21, 2024

Benchmark Results

master 803c555... master/803c55557a2dd6...
overhead/acrule/a+2 0.743 ± 0.021 μs 0.743 ± 0.027 μs 1
overhead/acrule/a+2+b 0.723 ± 0.017 μs 0.714 ± 0.019 μs 1.01
overhead/acrule/a+b 0.263 ± 0.0059 μs 0.254 ± 0.011 μs 1.04
overhead/acrule/noop:Int 25.9 ± 0.05 ns 26.2 ± 0.05 ns 0.988
overhead/acrule/noop:Sym 0.0364 ± 0.0057 μs 0.0434 ± 0.0059 μs 0.84
overhead/rule/noop:Int 0.0448 ± 0.0011 μs 0.045 ± 0.0011 μs 0.995
overhead/rule/noop:Sym 0.0546 ± 0.0031 μs 0.0548 ± 0.0026 μs 0.996
overhead/rule/noop:Term 0.0538 ± 0.0029 μs 0.0557 ± 0.0027 μs 0.967
overhead/ruleset/noop:Int 0.13 ± 0.0044 μs 0.129 ± 0.0036 μs 1
overhead/ruleset/noop:Sym 0.146 ± 0.0054 μs 0.148 ± 0.0037 μs 0.986
overhead/ruleset/noop:Term 3.01 ± 0.089 μs 3.22 ± 0.11 μs 0.935
overhead/simplify/noop:Int 0.143 ± 0.0036 μs 0.136 ± 0.0016 μs 1.05
overhead/simplify/noop:Sym 0.167 ± 0.0058 μs 0.157 ± 0.0041 μs 1.06
overhead/simplify/noop:Term 0.0361 ± 0.0016 ms 0.0368 ± 0.0015 ms 0.98
overhead/simplify/randterm (+, *):serial 0.0851 ± 0.0016 s 0.0878 ± 0.0024 s 0.969
overhead/simplify/randterm (+, *):thread 0.0501 ± 0.03 s 0.0523 ± 0.028 s 0.957
overhead/simplify/randterm (/, *):serial 0.212 ± 0.0061 ms 0.209 ± 0.0064 ms 1.01
overhead/simplify/randterm (/, *):thread 0.239 ± 0.0073 ms 0.239 ± 0.0079 ms 0.997
overhead/substitute/a 0.0591 ± 0.0016 ms 0.0602 ± 0.0015 ms 0.981
overhead/substitute/a,b 0.0523 ± 0.0015 ms 0.0528 ± 0.0016 ms 0.991
overhead/substitute/a,b,c 17.7 ± 0.63 μs 16.8 ± 0.67 μs 1.05
polyform/easy_iszero 29.4 ± 4 μs 30.5 ± 2.5 μs 0.963
polyform/isone 4.02 ± 0.01 ns 2.79 ± 0.01 ns 1.44
polyform/iszero 1.12 ± 0.036 ms 1.13 ± 0.027 ms 0.994
polyform/simplify_fractions 1.62 ± 0.047 ms 1.68 ± 0.055 ms 0.966
time_to_load 2.12 ± 0.017 s 2.12 ± 0.014 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Copy link
Member

@bowenszhu bowenszhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you add some tests?

@ChristophHotter
Copy link
Contributor Author

Yes, I added tests for Real and Complex syms.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (0288135) to head (78bcdb7).
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
+ Coverage   81.86%   81.92%   +0.06%     
==========================================
  Files          16       16              
  Lines        1908     1909       +1     
==========================================
+ Hits         1562     1564       +2     
+ Misses        346      345       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bowenszhu

This comment was marked as outdated.

Copy link
Member

@bowenszhu bowenszhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowenszhu bowenszhu merged commit 2afe8b9 into JuliaSymbolics:master Aug 29, 2024
7 of 10 checks passed
@ChristophHotter
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants