Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rules to distribute conj over sum and prod #680

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benneti
Copy link

@benneti benneti commented Dec 12, 2024

distributing conj makes it easier to apply the remaining rules

@benneti
Copy link
Author

benneti commented Dec 12, 2024

As this is my first PR in this repo pointers are very welcome.
To slighly expand on my thinking here: at the moment complex conjugating a longer expression including real variables stops the simplification. In a lot of cases this simplification would avoid this.
A very simple example @syms x::Real y::Number; conj(x*y)*x*y |> simplify which could not be simplified before an now becomes (x^2)*y*conj(y).

For me locally rulesets tests are all green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant