test: update codegen tests #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/fix-tests
branch
from
ba863c5 to
da3bd6d
Compare
devmotion
approved these changes
Jan 13, 2025
devmotion
reviewed
Jan 13, 2025
test/code.jl
Outdated
|
|
||
| @test toexpr(a^-2) == :($(/)(1, $(^)(a, 2))) | ||
| @test toexpr(a^-2, nanmath_st) == :($(/)(1, $(NaNMath.pow)(a, 2))) | ||
| @test toexpr(NaNMath.pow(a, -2)) == :($(NaNMath.pow)(a, -2)) | ||
| @test toexpr(NaNMath.pow(a, -2), nanmath_st) == :($(NaNMath.pow)(a, -2)) | ||
| @test toexpr(NaNMath.pow(a, -2)) == :($(NaNMath.pow)($(inv)(a), 2)) |
There was a problem hiding this comment.
What happens in this case?
There was a problem hiding this comment.
NaNMath.pow(a, -2) turns into a ^ (-2). Codegen adds the NaNMath.pow back in https://github.com/JuliaSymbolics/SymbolicUtils.jl/blob/master/src/code.jl#L141.
There was a problem hiding this comment.
I'll make it not do that if the exponent is an integer
devmotion
reviewed
Jan 13, 2025
src/code.jl
Outdated
| @@ -146,11 +146,13 @@ function function_to_expr(op::typeof(^), O, st) | |||
| return toexpr(Term(inv, Any[ex]), st) | |||
| else | |||
| args = Any[Term(inv, Any[ex]), -args[2]] | |||
| op = get(st.rewrites, :nanmath, false) ? op : NaNMath.pow | |||
| op = get(st.rewrites, :nanmath, false) || args[2] isa Integer ? op : NaNMath.pow | |||
There was a problem hiding this comment.
Do we need this at all, see #689? In any case, the existing check is wrong and should be
Suggested change
| op = get(st.rewrites, :nanmath, false) || args[2] isa Integer ? op : NaNMath.pow | |
| op = get(st.rewrites, :nanmath, false) === true && !(args[2] isa Integer) ? NaNMath.pow : op |
src/code.jl
Outdated
| return toexpr(Term(op, args), st) | ||
| end | ||
| end | ||
| get(st.rewrites, :nanmath, false) === true || return nothing | ||
| if !get(st.rewrites, :nanmath, false) || args[2] isa Integer |
There was a problem hiding this comment.
A bit safer:
Suggested change
| if !get(st.rewrites, :nanmath, false) || args[2] isa Integer | |
| if get(st.rewrites, :nanmath, false) !== true || args[2] isa Integer |
Additionally, I guess it would be more efficient to move this to the beginning of the function body?
AayushSabharwal
force-pushed
the
as/fix-tests
branch
from
5f43d01 to
194aa85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.