MultithreadedForm can cause deadlock

JuliaSymbolics · Jun 9, 2023 · 616ef52 · 616ef52
1 parent 962e2b4
commit 616ef52
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/Project.toml b/Project.toml
@@ -51,7 +51,7 @@ RecipesBase = "1.1"
 Reexport = "0.2, 1"
 ReferenceTests = "0.9"
 Requires = "1.1"
-RuntimeGeneratedFunctions = "=0.5.9"
+RuntimeGeneratedFunctions = "0.5.9"
 SciMLBase = "1.8"
 Setfield = "0.7, 0.8, 1"
 SpecialFunctions = "0.7, 0.8, 0.9, 0.10, 1.0, 2"

diff --git a/src/build_function.jl b/src/build_function.jl
@@ -264,9 +264,8 @@ function _build_function(target::JuliaTarget, rhss::AbstractArray, args...;
                        iip_config = (true, true),
                        parallel=nothing, cse = false, kwargs...)
 
-  if parallel == nothing && _nnz(rhss) >= 1000
-        parallel = ShardedForm() # by default switch for arrays longer than 1000 exprs
-    end
+    # We cannot switch to ShardedForm because it deadlocks with
+    # RuntimeGeneratedFunctions
     dargs = map((x) -> destructure_arg(x[2], !checkbounds,
                                   Symbol("ˍ₋arg$(x[1])")), enumerate([args...]))
     i = findfirst(x->x isa DestructuredArgs, dargs)