Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set_array for sparse arrays #115

Merged
merged 4 commits into from
Mar 13, 2021
Merged

Conversation

shashi
Copy link
Member

@shashi shashi commented Mar 13, 2021

@codecov-io
Copy link

codecov-io commented Mar 13, 2021

Codecov Report

Merging #115 (ef52c0e) into master (751031a) will increase coverage by 8.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   58.95%   67.47%   +8.52%     
==========================================
  Files          13       13              
  Lines         972      993      +21     
==========================================
+ Hits          573      670      +97     
+ Misses        399      323      -76     
Impacted Files Coverage Δ
src/build_function.jl 68.46% <100.00%> (+13.30%) ⬆️
src/linearity.jl 60.86% <0.00%> (+3.26%) ⬆️
src/register.jl 67.64% <0.00%> (+4.01%) ⬆️
src/num.jl 63.44% <0.00%> (+8.00%) ⬆️
src/linear_algebra.jl 94.17% <0.00%> (+8.73%) ⬆️
src/utils.jl 67.53% <0.00%> (+9.09%) ⬆️
src/variable.jl 73.13% <0.00%> (+9.49%) ⬆️
src/diff.jl 83.07% <0.00%> (+9.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 751031a...ef52c0e. Read the comment docs.

@shashi
Copy link
Member Author

shashi commented Mar 13, 2021

@codecov-io excuse me?

@ChrisRackauckas
Copy link
Member

you heard it

@ChrisRackauckas
Copy link
Member

It's because the separate test groups

@ChrisRackauckas ChrisRackauckas merged commit b812742 into master Mar 13, 2021
@ChrisRackauckas ChrisRackauckas deleted the s/fix-sparse-set_array branch March 13, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slowdown with build_function output in recent versions
3 participants