Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompile symbolic_solve in SymbolicsGroebnerExt.jl #1233

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

zengmao
Copy link
Contributor

@zengmao zengmao commented Aug 24, 2024

Currently, symbolic_solve, which uses the Groebner.jl package extension, takes about 20 seconds to run for the first time on my laptop for very simple linear equations. I've added precompilation statements (using PrecompileTools) in the file SymbolicsGroebnerExt.jl to significantly reduce the latency for users, following some discussions on Discourse:
https://discourse.julialang.org/t/new-symbolic-solver-for-symbolics-jl/

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.81%. Comparing base (47cfd60) to head (13d46cd).
Report is 13 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1233       +/-   ##
===========================================
+ Coverage    8.30%   79.81%   +71.50%     
===========================================
  Files          46       46               
  Lines        4549     4622       +73     
===========================================
+ Hits          378     3689     +3311     
+ Misses       4171      933     -3238     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 046d2ef into JuliaSymbolics:master Aug 24, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants